Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused hasOperatorList code #5571

Merged
merged 1 commit into from
Dec 27, 2014
Merged

Remove unused hasOperatorList code #5571

merged 1 commit into from
Dec 27, 2014

Conversation

timvandermeij
Copy link
Contributor

Originated from f8f4b3f#diff-c18ac71361bc452920c40076a5937b3dR485 but has been unused since then.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/545259581bf41fb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/545259581bf41fb/output.txt

Total script time: 0.76 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/3eaa2db6dfeb005/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/15b54d33cf068c3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/3eaa2db6dfeb005/output.txt

Total script time: 17.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/15b54d33cf068c3/output.txt

Total script time: 22.96 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor Author

@Snuffleupagus Do you have time to review this PR too? It should hopefully be an easy one :)

Snuffleupagus added a commit that referenced this pull request Dec 27, 2014
@Snuffleupagus
Merge pull request #5571 from timvandermeij/annotation-rewrite-2
50fe7c8 
Remove unused hasOperatorList code
@Snuffleupagus Snuffleupagus merged commit 50fe7c8 into mozilla:master Dec 27, 2014
@Snuffleupagus
Copy link
Collaborator

If this code would have been necessary, I assume that the method should have been present for all annotations. Hence I agree that removing it seems reasonable, since it's not actually used anywhere.

Thanks for the patch!

@timvandermeij timvandermeij deleted the annotation-rewrite-2 branch December 27, 2014 12:24
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
@Snuffleupagus
Merge pull request mozilla#5571 from timvandermeij/annotation-rewrite-2
a294e1d 
Remove unused hasOperatorList code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timvandermeij @pdfjsbot @Snuffleupagus